Take a look at the test?

Question

JavaScript

Good afternoon!
Relatively recently I did a test for aviasales, sent it to them, but did not receive feedback.
Can I get it here? Thanks in advance for any criticism or advice)
Github

Answer 1

Just for the presence of .gitconfig and .DS_Store, I would no longer consider you as a candidate - this means that you basically do not understand how this can interfere with other people, which means that in principle you did not participate in team projects. Moreover, you did not bother to study how it happens there. I am sure that in this company even juniors are considered from those who understand something about this.
Next, I honestly cloned your app and tried to run "npm run test:style". It turned out that there is no such script. At this point, the review was over, as it became clear that you were either extremely inattentive, since you didn’t include this script in the working version in the master branch (or vice versa, you didn’t delete it by copying the template from somewhere?), Or you don’t understand what you are doing in principle, picking up tops from somewhere, compiling someone else's experience, and so on.
There is no point in looking for the original source of your code, and it is so clear from two paragraphs that as a candidate you are not the best option - you will either have to spend money on your training even in such bases, or realize that you just could read something somewhere, partially understand and end up trying to deceive, pretending to know something.

Answer 2

it's good that you are trying to improve your solutions, no solution can be made immediately the best, it's always a way through improvements.
In Russian companies, there is just some kind of hell going on in the standards of working with candidates, giving a test task (which the applicant will spend a week on) and then not even answering him - this is quite a common practice.
My advice: never do any test tasks again, they are useless for employment (and it’s useless to develop them for learning, as these are just some unnecessary separate tasks in a vacuum, and not a full-fledged project).
Develop your projects, participate in other people's open source projects, participate in competitions, etc. -> this ALWAYS gives you much more value. And whoever wants to "stretch" you for a "test" - send them links to finished works, such a scheme is more effective.
Otherwise, you will get bogged down in endless, useless test tasks.

Answer 3

here is the same test a week ago, compare

Answer 4

The first thing that caught my eye was why do you have business logic in actions? The actions folder usually contains only the actions themselves and 'action builders', in my opinion it's not good when one action generates some promises, implements some kind of logic, etc. Actions should just be a declaration that we want something to do, and the logic should be elsewhere.
Well, I agree with the previous commenters. Especially the presence of extra files and folders like .gitconfig and build in the project is alarming - even a junior should understand the basics of working with modern tools.