Answer the question
In order to leave comments, you need to log in
Why is a large/large pull request bad (or good)?
The situation is this:
there were a lot of PRs in the intermediate branch, they were reviewed by the team to which the developer who made the PR belongs;
then all these commits / changes were merged into one PR and it became like a page with the contents of a book with dozens of commits, at the same time, developers from other teams joined the review and the review is delayed for several more days;
For me, such large PRs are a problem, I don’t understand how to review them, they look monstrous and defy understanding. And the question is - how to be in this situation? Is it worth asking for reviews from developers from other teams when there is a review in an intermediate branch, or should we leave this hell as it is?
PS The more detailed the answer, the better. You need to understand the topic as much as possible. Thank you )
Answer the question
In order to leave comments, you need to log in
there were many PRs in the intermediate branch, they were reviewed by the team to which the developer who made the PR belongs;
then all these commits / changes were merged into one PR and it became like a page with the contents of a book with dozens of commits, at the same time, developers from other teams joined the review and the review is delayed for several more days;
Size matters, sometimes!
Your task is to have a pull request that matches your task.
If you changed the ORM, then this is one thing, but if you added a pink login button, then it’s completely different.
In my work it was both. 2-month work was thrown into the main branch, because it was necessary.
And there were little things because "here we all finished this unit"
Stick to the scheme when any operation in the git creates or fixes some kind of task
incomprehensibleIt seems that this is the main requirement for PR - that it would be understandable.
Didn't find what you were looking for?
Ask your questionAsk a Question
731 491 924 answers to any question