What code to show to the customer/employer?

Question

Career in IT

Introduction: we assume that the portfolio (for example, on github) will be viewed by a professional developer who knows the language perfectly. What is the best thing to show?
Online store or corporate website? Trite. On a framework? Well, this is probably a little better))
How to show your knowledge of algorithmization? Solve some difficult problem in your programming language? You had to evaluate someone else's code, what you looked at (well, except for indents and variable names) )))
UP: Let's not be unfounded there, the code completely works, solves the problem, there are no obvious crutches such as suppressing errors by a dog, but variable names not really, like a, b, row, foo, etc. Or some non-obvious thing is worth something like this. How bad is echo inside a method?Or are you used to the fact that a variable is returned, and a person loves arrays and returns arrays everywhere. You are used to json and it uses explode or serialize / unserialize

Answer 1

What I personally would pay attention to:

1. Code formatting. All code must strictly adhere to the same style. Ideally, if it complies with the current standard, for example PSR-2. Necessarily speaking variable names, no a, b, row, foo and other tin. Naming classes according to the name of the pattern used. The code should be self-documenting. Required everywhere PHPDoc comments in accordance with the standards. Comments with descriptions of particularly difficult places.
   
2. If this is a framework, then it is in accordance with the standards and recommendations adopted in the framework. No self-activity.
   
3. General architecture of the project. No footcloths in controllers. Clear breakdown of code by service. No hellish functions over 100,500 lines. Logical division of code into classes. Applying appropriate patterns to solve problems.
   
4. Minimum number of bicycles. If there is an excellent library for solving a problem, and a person writes his own crutch, this is a clear minus. If there is a ready function - similarly. Except when the ready-made library is not suitable for something.
   
5. Using a package manager for a project. Well, I think in 2016 no one will code without it :)
   
6. I think I would not understand the operation of complex algorithms, and limited myself to what I listed above.
   
7. I would prefer framework code. It is also not bad if it is a prefabricated hodgepodge on ready-made components, sharpened to suit your tasks.
   
8. Full self-writing is a clear minus. Not using good off-the-shelf solutions these days, making dumb, obscure bikes instead, is stupid.
   
9. You don't even have to send a code to the CMS. In any case, there will be govnokod. CMS themselves oblige this :)
   

Answer 2

Show everything you have on github and that's enough