Is it worth taking out the values ​​in variables or substituting them directly?

Question

PHP

2 options, in one the values ​​​​are placed in variables, in the other they are substituted directly, what is the right way to do it, in which cases do you substitute directly, in which ones should they be taken out separately?

//данные вынесенны в переменные
    public function actionGet_places($term) {
        if(!Yii::app()->request->isAjaxRequest)
            throw new CException('Попытка прямого доступа');

        $term = CHtml::encode($term);

        $sellersId = Yii::app()->user->getSellerId( ! Yii::app()->user->isSeller( Yii::app()->user->id) );

        $places = Yii::app()->db->createCommand()
                ->selectDistinct('place')
                ->from('trips')
                ->where('place LIKE :place AND sellers_id = :sellers_id',
                        [':place' => '%'.$term.'%', ':sellers_id' => $sellersId ])
                ->queryColumn();

        echo CJSON::encode($places);
    }

 	//данные подставляются на прямую
    public function actionGet_places($term) {
        if(!Yii::app()->request->isAjaxRequest)
            throw new CException('Попытка прямого доступа');

        $places = Yii::app()->db->createCommand()
                ->selectDistinct('place')
                ->from('trips')
                ->where('place LIKE :place AND sellers_id = :sellers_id',
                        [':place' => '%'.CHtml::encode( $term ).'%', ':sellers_id' => Yii::app()->user->getSellerId( ! Yii::app()->user->isSeller( Yii::app()->user->id) )])
                ->queryColumn();

        echo CJSON::encode($places);
    }

Answer 1

Personally, I create a variable when I start writing the same thing over and over. but in general I don’t think about such things for a long time, everything is done automatically.