Which option is better for singleton?

Question

PHP

What is the best option for implementing the getInstance method in the Singleton pattern?
one.

public static function getInstance()
{
    return self::$instance ? : self::$instance = new static;
}

2.

public static function getInstance()
{
    if (!static::$instance) {
        static::$instance = new static;
    }

    return static::$instance;
}

Answer 1

My opinion - you can not use ternary operators anywhere, as they worsen readability. Second option.

Answer 2

And I see you do not calm down in any way.
From the point of view of the specific implementation, there is no difference, from the point of view of code readability - the second option.
Just read the code:
1) return an instance if it exists otherwise return the result of assigning instance equals instantiating itself
2) if we don't have an instance, then we create it, then we return the instance.
stop chasing symbols for savings, and if we are talking about the underlying code, then it is better to choose a slightly more verbose option, but understandable to everyone from the first time.
And yes, singletons are good, but not very good. And if in your system there is a need for a base class for singletons and each component is built on its basis, you have problems with the architecture.

Answer 3

If someone else's opinion is so important, then I like the second option better.
In general, this is such an insignificant issue that I would not waste my life on such things.

Answer 4

It doesn't matter, the first option is shorter, only I would change it a little:

public static function getInstance()
{
    return static::$instance ?: static::$instance = new static();
}

Answer 5

There are, of course, religious preferences.

public static function getInstance()
{
    return self::$instance ? : self::$instance = new static;
}

From a programmer's point of view, such code is more attractive and faster. However, for teamwork, the old version is better. Otherwise, an evil programmer will come to you, who was looking for a bug after you and will take out the brain.