Answer the question
In order to leave comments, you need to log in
Where is the line of good enough reason to reject a Pull Request in a Code Review?
Question about the Code review by the team lead
Where is the line between what needs to be sent for correction and what can just be ignored? How high should the quality bar be?
Example - the code was written (my comments):
$averageSumPerMonth = Orders::getInstance()
->calculateAveragePricePerMonth(Auth::getAccountId()); // 15 or null
if ($averageSumPerMonth) {
$averageSumPerMonth = $accountService->getBalanceService()
->getAmountString($averageSumPerMonth, 0); // '15 рублей'
}
Answer the question
In order to leave comments, you need to log in
My opinion: if this is a hotfix - ok. But it should be noted that in the future this piece needs to be redone.
Similarly - if this is legacy support and in the future it will simply be thrown out.
In other cases, you need to rewrite so as not to run into code maintenance in the future.
Didn't find what you were looking for?
Ask your questionAsk a Question
731 491 924 answers to any question