D
D
Denis Pablo2020-07-13 21:57:32
PHP
Denis Pablo, 2020-07-13 21:57:32

What should I change in this project?

I am writing my own framework, in particular for myself, but if someone wants to use it, it is logical that I do not mind.
So: I've been writing it for so long and I need advice on eliminating unnecessary code for more optimized functions and, in general, what would be better to do.

Link to the repository : https://github.com/flowerphp/flower

As for the design of readme.md, I don’t find fault with it, I’m just writing a framework as soon as I add it, I’ll design it properly

I would not want to see answers or comments about the fact that there are already good engines and etc., as I said, I write in particular for myself and for my future projects

Answer the question

In order to leave comments, you need to log in

1 answer(s)
D
Daria Motorina, 2020-07-13
@fl3xice

1) in the repository you get a skeleton rather than a framework package, the templates folder should have a conscious purpose, e.g. welcome page, the public folder is also usually missing
2) naming interfaces as iSomething is morally outdated and incorrect according to PSR (for classes too, there was a reCaptcha class)
3) tests should reflect tests for the functionality of the framework, while there are stubs
4) the Promises layer is incomprehensible, under it shows a lot of classes that are responsible for different things, it would be worthwhile to structure them, the prefix extreme also does not reflect the purpose of the classes
5) it is strange to see a recaptcha class in the core, this is a typical client task and the framework should not solve it
6) now there is a tendency to include third-party orm in the framework, because designing abstractions for the base from scratch is a huge job

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question