Answer the question
In order to leave comments, you need to log in
What shortcomings can you tell about the code?
https://github.com/AntimatteryCreator/seawarship
This is my test task, I want to get criticism, I want to get a junior job on js. The company said it was weak. To my question "where is it weak?" and "what to pull up?", I got no answer. The turnaround time was 2-3 days. What I managed to write in 3 days I sent. I wrote everything myself. Dear people, who understands more, tell me, please, in which direction should I teach?
Answer the question
In order to leave comments, you need to log in
High cyclomatic complexity of such a code . Business logic is mixed into the DOM. Almost all code is duplicated.
This kind of code is hard to maintain. Difficult to read. Difficult to test. It's really weak. Yet we write for people, not for the computer. Writing complex code is very easy. Writing simple code is very difficult.
It bothers me
let ships = {
'OneShip': 4,
'TwoShip': 3,
'ThreeShip': 2,
'FourShip': 1
};
function init(startgame) {into small ones, because it is not clear what happens in such structures
Didn't find what you were looking for?
Ask your questionAsk a Question
731 491 924 answers to any question