U
U
Uncle Bogdan2021-12-27 21:56:38
code review
Uncle Bogdan, 2021-12-27 21:56:38

What level am I at now?

Hello! I'm interested to know at what level I'm at sharpe now. I wrote this simple console program. I would be grateful if you rate the code!

repository

Answer the question

In order to leave comments, you need to log in

4 answer(s)
V
Vasily Bannikov, 2021-12-27
@motkot

1. You don’t know how to use git, because you uploaded files via Upload
2. It’s impossible to check the code, because you uploaded only cs files, but didn’t attach an equally important csproj - you don’t understand how the project is going.
3. You have already been told about the switch case in the comment.
Little can be said about the rest - the code is the most common, by three with a minus, not very good, but not too terrible either.
The architecture is bad, because the implementation details are mixed with business rules.
Algorithms cannot be evaluated, since there are no complex algorithms in your project.
Level, IMHO: trainee / junior developer (necessarily under the mentorship and supervision of a more experienced one)

L
lutokris, 2021-12-28
@lutokris

Unfortunately, I'm just starting to learn Python, Django, but why does it seem to me that you wrote something like HelloWorld))

S
Saboteur, 2021-12-28
@saboteur_kiev

There are levels in Tetris. Or in thought.
And in development there are grades that change from one company to another like heaven and earth.
Go to an interview and find out.
Nothing can be understood from the written program. Common use of standard functions.
No one knows who came up with the terms of reference and requirements for it, and how accurately they were fulfilled.
There is no adequate description of the program to understand why it should be used.
That is, the code itself is very simple, and the approach to writing the product is slurred.

V
Voland69, 2021-12-28
@Voland69

Opened the first file in the turnip:
1. What is the purpose of GetCompanyById if the same collection has read access from outside?
2. What happens if I feed -1, 0, 100500 into this method?
I join the rest of the comments (there is no project file, no readme, etc.).
That is, now it's not even a program - but a set of source codes, for which framework / SDK, for which environment?
I can throw it into the project under the .NET Framework 4.0 and say that you have a dozen errors here.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question