Where is the best code quality?

Question

PHP

With a colleague, an eternal holivar about the quality of the code.
Here is one example.
Please rate how it is correct to write in such pieces)
1)

if (!$_SESSION['isMobileOnly']) {
    $opinionList = $dao->getOpinionList($bar['id']);
} else {
    $opinionList = $dao->getOpinionList($bar['id'], 3);
}

2)

$opinionList = $dao->getOpinionList($bar['id'], $_SESSION['isMobileOnly'] ? 3 : null);

3) Your option)

Answer 1

Everything is bad

• Global variables are evil
  
• On the face of a certain code that works with the session and with the database - a clear violation of generally accepted principles, such as SRP
  
• $dao how is it initialized? Obviously not through the constructor
  
• Using a number, just sit and guess from it - this is bad, use a named constant. For example, 3 is a certain status for desktop, so call it STATUS_DESKTOP, although further...
  
• you are referring to one method, which is very smart - it works with flags, thereby violating SRP and itself contains if / else, just make 2 separate methods:
  

  getMobileOpinionList()
  getDefaultOpinionList()

  
  
• It is better to move the predicate into a separate isMobileOnly() method, because the conditions can change in it, you won’t change it everywhere in if throughout the project
  

Answer 2

$deviceCode = $_SESSION['isMobileOnly'] ? 3 : null;
$opinionList = $dao->getOpinionList($bar['id'], $deviceCode);

Answer 3

The first option is visually easier to disassemble than the second.

Answer 4

Wrap the session in an object, use types wherever possible.
See https://symfony.com/doc/current/components/http_fo...
ps Move the number 3 into a named constant.

Answer 5

In order of increasing entropy:

$opinionList = $dao->getOpinionList(
    $bar['id'], 
    $_SESSION['isMobileOnly'] ? 3 : null
);

Answer 6

No one! What is the number 3, why is it not made into a constant, if it is so important. It's like you're only writing for yourself..