S
S
sivabur2015-05-15 00:15:44
C++ / C#
sivabur, 2015-05-15 00:15:44

What are the shortcomings in the code / your opinion about this code?

pastebin.com/nYQthueL
Criticize the code.
What elements of OOP should be implemented in applications of this type / design patterns.
What can be implemented best or what are the best practices.
Where can I make the optimal one so that there is less code so that it is easily readable.
Perhaps it is more appropriate to use other libs.

Answer the question

In order to leave comments, you need to log in

1 answer(s)
V
Vitaly Pukhov, 2015-05-15
@sivabur

As far as I understand, this is a page parser of some site with support for several proxy servers, the parsed is stored in the database, I don’t see any special crutches in the code, everything is quite simple and relatively clear. From what I noticed, the abundance of reports from the worker looks strange, even in those places that are processed in a split second, if the UI thread is updated according to the report, this can slow down the work. For readability, I would remove extra comments (old code) and extra line breaks (empty lines). Another separate point is the abundance of messagebox, in the work you probably need to constantly poke "OK" so that everything continues to work, I would replace this with an output to the log or to a separate field in the UI, whoever needs to see it himself, a working application usually does not need it.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question