The if or switch construct?

Question

PHP

The question is simple and stupid. Two versions of the same code. How would you write and why? The names of methods and variables do not matter.

if (
  $this->inComplete($oldStatus, $newStatus) ||
  $this->outComplete($oldStatus, $newStatus)
) {
  $this->action();
  $this->save();
}

switch (true) {
  case ($this->inComplete($oldStatus, $newStatus)):
  case ($this->outComplete($oldStatus, $newStatus)):
    $this->action();
    $this->save();
}

Answer 1

in this particular case, switch is clearly not needed.
switch is needed when you have a variable that you want to compare with different values ​​and do different actions depending on this. And you generally write true as a switch condition, and case without completion is, from the point of view of readability, a very implicit OR.

Answer 2

The second option is a good attempt, but not fully implemented. You have to write like this

(function() { 
    foreach([true] as $condition) {
        $condition = ($condition) ? true : false; 
        while ($condition) {
            switch (true) {
                case ($this->inComplete(($oldStatus), ($newStatus))):
                case ($this->outComplete(($oldStatus), ($newStatus))):
                    ($this->action());
                    ($this->save());
            }
            break;
        }
    }
})();

In general, before asking a question on the toaster, you need to sit down and first think carefully about what meaningless statements you can add to the code, except for switch.

Answer 3

If in which would call one wrapper method returning a bool value.