S
S
subsetofmultiset2021-07-12 05:37:38
code review
subsetofmultiset, 2021-07-12 05:37:38

Review of the TK, for which the refusal. What grave mistakes did he make?

Good afternoon. Responded to the vacancy by completing a test task. (rejected)

Tried to separate the domain from the infrastructure/framework to reduce coupling and in case of expansion it was easy to maintain. Instead, I had to write custom solutions, losing in readability / understanding of the code, due to the fact that the solutions are not standard

. Is it worth removing the separation between the domain and infrastructure? Can you please tell me what gross mistakes I made and what can be fixed to improve the quality of the code?

Repository (click)
Test task (click)

Answer the question

In order to leave comments, you need to log in

1 answer(s)
A
approximate solution, 2021-07-12
@subsetofmultiset

Maybe she has already found a specialist and it was already expensive to conduct your code review.
60ebe969797eb243490749.png
For example, 100+ people are knocking on this vacancy, each sends a test task.
Factors: speed of execution, adequacy of the interlocutor, personal preferences. Some factor did not play in your favor, and most likely you dropped out at the level - "so, the technical task was completed, but Vasya Pupkin from Saratov did it 2 hours faster, + I liked HR or the technical lead."
Bottom line: don't be discouraged, doing a code review for each potential candidate is money and time. Not all companies are ready to pour out the surplus.
PS: last month we received 320 resumes + terms of reference for the position of junior, we stopped at 150 resumes, conditionally we found all the candidates, the remaining 170 were most likely at a loss. That's business :)

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question