V
V
VegasChickiChicki2018-12-15 05:38:01
code review
VegasChickiChicki, 2018-12-15 05:38:01

Please rate the layout, what am I doing wrong?

I guess there are already a lot of such topics here, but still I decided to create one. Everything is as usual, appreciate it, help me find mistakes in what I do, in what places the crutches, in what places it is better to redo and so on. I would also like to be explained about the benefits of SASS, otherwise I seem to be using it, and all the pluses that I found are that you don’t need to put brackets and a semicolon :), but how to use it more efficiently in layout, I still I can’t understand (
As for JS, everything is simple, I wrote everything myself, but since it’s still difficult for me to navigate in it, it came out not quite literate, although it works.
Link to git https://github.com/VegasChickiChicki/VegasChickiCh...
Link to the site https://vegaschickichicki.github.io

Answer the question

In order to leave comments, you need to log in

2 answer(s)
A
Anatoly, 2018-12-15
@Tolly

For starters, the site is very heavy 15Mb, you need to reduce at least a maximum of .5Mb.
PS. According to criticism, watch all the videos https://www.youtube.com/channel/UCaTfYudJUVA8cV_Bu...
then you will evaluate your site yourself.

L
lamer350, 2018-12-15
@lamer350

Unfortunately, it is too early for you to submit your work for evaluation.
In answer to your question, one thing can be said: You are not studying, but you want us to do everything for you.
It’s worth starting with the fact that there are more materials on SASS on the Internet than you need, you apparently didn’t even try to figure it out.
From the site, we can conclude that you didn’t even understand HTML that much, you don’t even know how to use HTML tags (we are talking about HTML5).
A separate question should be given to the site graphics, after I opened the background at ~ 7000 pixels in height, I didn’t look further, especially the choice of PNG was embarrassing.
There is simply nothing to disassemble in your work, you need to start with the basics. I don't even want to mention JS at all.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question