K
K
kyzinatra2019-11-06 07:39:24
code review
kyzinatra, 2019-11-06 07:39:24

Could you rate my layout?

Hello, could you rate my layout.
I did it with gulp, npm, less, pug.
And jQuery, animeJS, Font Awesome, wowJS, mousetrap, slick-carousel, easy pie chart libraries.
I would like to hear your assessment and criticism , what can be improved / done or what to pay attention to.
Thanks in advance for your time :D
my-webportfolio.ru

Answer the question

In order to leave comments, you need to log in

3 answer(s)
R
Robert-critical-thoughts, 2019-11-06
@kyzinatra

Some relevant criticism:
1. Не называйте то, что вы сделали - frontend.Those technologies that you described above are more suitable for the category of the layout designer profession. Because you just made up the layout, connected scripts to it, you don't need to be a genius here. Knowledgeable people will dig in, and I will spread rot, because "the very concept of frontend is respected to the point of snobbery." It’s better to write a web developer, or a layout designer - being a layout designer in 2019 is not shameful, since in the front-end this is one of the “true”, and most of the “gurus”, don’t even know the tags, sculpt divas.
2. B header- the text under the description merges with the background, this is very bad in terms of usability, usually they tear off their hands for this.
3. No need to make 2 tags header- in the markup. One is enough header- and it is divided into header__navigation, header__content- so logically it will be more correct.
In the rest - the usual site, no better and no worse. Like from 2010-x.

B
BATPYIIIKOB, 2019-11-28
@BATPYIIIKOB

If the design was the same, then the layout will work!
By design:
1. Typography is just nothing. Do not make a black stroke on a dark background. Choose interesting modern fonts
2. Urgently change the background on the main page!!! At first I thought that my glasses were dirty.
3. The background is dark! Plus the colors are weird. A dark site is harder to read if it's not WOW!
4. Huge block shadows are not fashionable
5. Why do blocks and strokes at all, it's clear from the headings where the section begins...
5.1. Yes, and navigation should lift up the title.
6. Rounded blocks combined with panels with right angles... 90s and more strokes..
and so on...
7. Visit https://www.awwwards.com/ more oftenand study which sites are in trend, which fonts and colors.
I'll add: All the same, I climbed the layout:
1. header__nav nav - FUCK!!!!!! __ - what's this??? how did I get tired of raking the templates after __. Who taught you to do __ ????? If you do follow then BEM! And just shove from the bulldozer everywhere .... inappropriately
2. Indents - 4 SPACES .. 4 !!!! not how you like it.
3. /> - optional, no longer needed. Simply >
4. Why ?! They're on the same level. h1,h2,h3 - this is not the font size.... 5. If you spread the layout and ask to check it out - then: DON'T MISS IT!!!! how to see css ? ..... <h1>Мое резюме</h1> , а <h2>Мои контакты</h2>

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question