B
B
Bob_102020-06-10 14:36:15
code review
Bob_10, 2020-06-10 14:36:15

Rate the layout?

I got carried away with the layout. For a while I read the documentation, watched the lessons, etc. Experimented and practiced. As a result, I decided to make up my first small project. I ask you to evaluate my work, point out the shortcomings, how best to do it is not worth it, but how it should be done. In what direction should I develop further? (If we talk about the Front).
The work itself is located on GitHub, links below:

1. https://github.com/bobr-10/first-work - files.
2. https://bobr-10.github.io/first-work/ - the site itself, the adaptive tried to make it up to 320px.

Answer the question

In order to leave comments, you need to log in

1 answer(s)
D
Denis Ineshin, 2020-06-10
@Bobr_10

With layout, everything is fine. Better than many. But the CSS immediately alerted:

* {
    margin: 0;
    padding: 0;
}

You can't do that. Instead of such a clumsy reset of indents for all elements. It is better to use a normalizer:
https://necolas.github.io/normalize.css/
And yet, the adaptive should be done the other way around. At first, for mobile phones, then for something bigger. Google mobile-first

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question