Rate the app?

Question

Angular

Help evaluate the application and poke where you can do better
https://github.com/BuG1K/task/tree/master/src/app

Answer 1

It is better to specify the type not through the primitive constructor, but through the string type (the one from TypeScript, with a small letter). You are not using RxJS features. This piece of code can be done differently:

ngOnInit() {
    this.Preview.url
      .subscribe(new_url => this.url = new_url);
  }

The subscriber will not be destroyed when the component OnDestroy, but will listen to a new url until it is unloaded from memory by the garbage collector. It would be better to do it like this:

public previewUrl$: Observable<string>

ngOnInit() {
    this.previewUrl$ = this.Preview.url
}

<div class="preview" *ngIf="(previewUrl$ | async) as url">
  <img class="preview__img" [src]="url">
</div>

In the service as well ( https://github.com/BuG1K/task/blob/master/src/app/... you subscribed to the http request and do not use RxJS any more. All manipulations could be done in tap / map and return stream that is easy to work with.