On programming style: Should you wrap the parenthesis?

Question

Programming

We are coming to a common programming standard in the company. Many things have been discussed, it remains to solve the issue with the curly brace :)

Some people are used to putting the brace on the same line with the function identifier, others transfer it to a new line. The advantages of writing in one line are only that a line of code is saved, the advantages of transferring are seen in a clearer traceability of the logical block of code and, accordingly, a quick search for the necessary elements and editing.

I would like to discuss with you, which is more correct? At the same time, the goal is not just to develop a program, but to make it easy to understand in the future (both for the developer himself and for a third-party), expand, refactor, etc.

How do you act in your company when you work in a team?

Below are two variants of the same function as an illustrative example.

<?php
// вариант 1
function f1(a, b) {
  if (a == 0) {
    a *= f12() + f15(a);
    b = f2(1, b);
    if (b > 15) {
      f4(a);
      f5(b)
    }
    if (a > 17) 
      f86(a);
    return f6(a, b);
  }
  return f7(a, b);
}

// Вариант 2
function f1(a, b) 
{
  if (a == 0) 
  {
    a *= f12() + f15(a);
    b = f2(1, b);

    if (b > 15) 
    {
      f4(a);
      f5(b)
    }

    if (a > 17) 
      f86(a);

    return f6(a, b);
  }

  return f7(a, b);
}
?>

Answer 1

There is no “correct” option, there is one adopted within the framework of this group of developers.

Answer 2

Until recently, where I work, it depended on the language and even the framework (if any). The day before yesterday, I just got tired of seeing 2 different options within the same screen, and now we have the transfer option everywhere.
The wrapping option was chosen because visual structure and readability are more important than the number of lines of code.
PS For the option without wrapping in pascal-like languages, you just want to kill:

var i : integer;
function rock(hard: boolean); begin
   for i := 1 to 10 do begin
       //do something
   end;
end;

Answer 3

Pay attention to code standards PSR-2 , Zend Framework , PEAR .

Answer 4

There is one good argument in favor of not wrapping:
return {
val: 'text'
} - works
return
{
val: 'text'
} - no

Answer 5

Practice shows that the following method works well (not a panacea!):
- blocks if, for, etc. are highlighted with empty lines before and after the block
- brackets are always put, even if the body is one operator
- the opening bracket is not transferred to a new line
- if the description of the operator is spread over several lines - simplify to fit on one line, by any kind of refactoring
example:

function f1(a, b) {
    if (a == 0) {
        a *= f12() + f15(a);
        b = f2(1, b);

        if (b > 15) {
            f4(a);
            f5(b)
        }

        if (a > 17) {
            f86(a);
        }

        return f6(a, b);
    }

    return f7(a, b);
}

Answer 6

There is no correct option, there are such options:
1. There are already a bunch of ready-made styles, take read the recommendations for your language / framework, use it
2. Throw a coin
3. Vote and choose by majority
4. Let the most experienced of you choose

Answer 7

It depends on the language for me:
- it does not transfer to JS due to the large number of callback functions. If you transfer, then readability drops
- in Ruby, skims are used only for very short blocks in one line
- in the rest, transfer to clearly see the boundaries that highlight the brackets.

Answer 8

Java, not portable.

Answer 9

Everyone has their own style of writing, for whom it is more convenient and as is customary in the team. I always move the bracket to a separate line, for me the code becomes much more readable and convenient.

Answer 10

I transfer when declaring a class / method / function, I do not transfer in other cases. I stopped at this due to the fact that the frameworks I use most (Yii, ZF) use this approach.

Answer 11

As they said, there are no right options, but ...
McConnell gave a good explanation, whose opinion, by the way, I adhere to.
A well-designed language has an explicit block structure that results in a natural style of indentation. For example VB:
If a= b Then
statement1;
…
End If
That is, to emulate an explicit block, you can do this:
if (a == b) {
statement1;
…
}
This style allows you to show the logical structure of the code.
Wrapping a parenthesis breaks the integrity of the block, giving the appearance that they are neither part of the control structure nor part of the inner block.
As an alternative

Answer 12

While I work alone, I write in a way that would please my eye, with a bunch of empty lines for readability and other oddities. But if we are talking about teamwork, then it is better to use a popular standard. I would choose PSR-2 .

Answer 13

I never wrap an opening parenthesis on a new line.

Answer 14

And I decide depending on the IDE. If the IDE automatically puts a closing bracket for me, then I don’t transfer it, and if it doesn’t put it, then I transfer it, because otherwise I will have to press the end key all the time, which is not convenient. Both are readable for me.

Answer 15

We write in Ruby, we do not experience such problems.

Answer 16

I was developing in C++ a long time ago and always carried the parenthesis. I don’t know why, but almost all the listings that I saw then were with transfers.
Now, when I'm developing on Java, everything was decided easier. In most IDEs, when autoformatting is selected, this happens automatically. I do not argue that this, in theory, can be customized, but by default, the 1st option is everywhere. And since it’s too lazy to set up this customization every time, the question disappeared by itself.

Answer 17

I can't stand. By the way, in JS it's not just a matter of taste:

return {
  a: 5,
  b: 7
}

will return the object as expected,
but

return 
{
  a: 5,
  b: 7
}

will just terminate the function. For the convenience of the programmer, the interpreter itself will substitute a semicolon immediately after return

Answer 18

1TBS vs K&R vs…
en.wikipedia.org/wiki/Indent_style
Personally I prefer K&R.
It will become boring - do not forget to chill out on the subject of tabs vs spaces.

Answer 19

I write in Java for Android, I use
Allman style, PSR-2 standard