Need constructive criticism bash script

Question

bash

Good afternoon,

We have been working with Linux not so long ago, so I ask you to look at the script for starting / stopping the service.

The script itself is here - pastebin.com/NgdPgQLx

Thank you very much!

Answer 1

I'd

SCRIPTNAME=/etc/init.d/$NAME

replaced by

SCRIPTNAME=`readlink -m $0`

Because if you change the NAME, but do not change the file name, you can get an error when using the SCRIPTNAME variable. Now, in reality, it does not contain the data embedded in the meaning of the name.

Answer 2

Try upstart if your system has it (i.e. if you have Ubuntu). Everything is much simpler there, for example, you do not need to write all this triviality that occurs in every first script from SystemV.