N
N
Nikita Kit2019-04-16 20:42:56
Work organization
Nikita Kit, 2019-04-16 20:42:56

How would you feel about a dependency-free front-end development approach?

I welcome everyone.
I have a difficult situation in my new job. I got a job in the company as a front - lured by promises of a new project on angular 7 in the near future. I went through social security, accepted the offer. Until the start of a new project was given, I was tied to another project. I will not give names so that without publicity (in accordance with the non-disclosure agreement). Its front is approximately 70% written. When I saw what was happening there, I was horrified.
1) Only jquery + bootstrap is used. All modules of sliders, galleries, popovers are written by hand.
2) The project is divided into 2 repositories. The first is bare statics, the second is a full-fledged working repository with backend in java. Both have well-established differences in scripts, the part when statics is simply irrelevant.
3) SCSS is applied a la 2012. Modules are divided into sections with media queries, selectors are stupidly copied from section to section instead of describing the entire styling, including media queries in one selector.
4) The whole markup is simply teeming with bootstrap helpers, sometimes there can be up to 15 helper classes in one block. Unreadable gesture.
I have already turned a blind eye to the sectional division of selectors by media queries - tolerably, albeit unpleasantly.
I implemented a couple of modules in typeScript using dependencies in the very first tasks. Swiper - for viewing the gallery of catalog pages with the ability to zoom the page and popper.js (which is in bootstrap even without installation) for debugging their crooked self-written popover.
At the very first code review, the author of this slag forbade me to inherit bootstrap helpers through the scss extend directive, asked me to replace swiper with his self-written slider - even though it pissed me off, I endured it, figured out its code, added it, wrote my slide zoom with my hands.
When he disapproved the changes in the popover, I simply could not stand it. He asked me to return and apply his crooked code, the layout of which went through any sneeze. I went to the project manager and expressed everything that I think about the front of the project, about the inadmissibility of such an approach in production, said that I want to quit - I really wanted to leave. I came to get experience with the latest angular, but got hit in the head with self-written statics and a bunch of someone else's code.
He convinced me not to make hasty decisions and promised to call a meeting of front-end developers from other projects, which would give me a chance to speak out about all the jambs and rakes that I stepped on. He promised that they would listen to me and make a general decision on the need for changes.
I want to ask the community, what would you do? Before that, I had been sitting tightly on vuejs for a year and a half - I was not childishly pleased with this frame. I hoped for experience with angular - for general knowledge (anyway, I expected to convince the guys to use vue after the page of the angular docks about dependency injection). And then they roll me into such a bottom. I understand that at any moment I can leave, find a company that wants vue no less than me. But the perfectionist/lenin in me doesn't want to give up so easily, and hopes for the support of the guys from other projects of this company.

Answer the question

In order to leave comments, you need to log in

1 answer(s)
A
Anton Shvets, 2019-04-16
@Xuxicheta

You should not download the rights and leave your point of view only by coming to the company and quarreling with the local lead from the doorway. First you need to do tasks. So, as is customary here. Understand everything and slowly move the boat in the right direction, having already gained some weight in the company.
Of course, speak out at the meeting, but don’t get much support, you are a new person, no one will rush to rewrite the entire project because of a newcomer. It’s easier for management to leave the project with a proven developer than to wait until the new one breaks everything for six months, without any guarantee that he can do better at all. Having a point of view is good, but you also need to understand when it is appropriate, and when the potential profit will exceed the inevitable losses in rebuilding.
Well, the arguments extolling Vue over Angular only betray your greenness. The advantage of Vue is only in the ease of learning, and Angular is already a serious framework built according to classical principles.
upd. And I will add - for business it is important that the project works and makes a profit. And it doesn’t matter on what framework, on what technology it is made. These things only matter in the context of finding new developers in the market. The choice of tool is secondary to the implementation of the business functionality.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question