R
R
Rad1us2015-11-08 17:31:58
css
Rad1us, 2015-11-08 17:31:58

How do you like this layout from a beginner?

Exactly one month ago I started learning HTML. I decided to take it because it is trite interesting and for the sake of broadening my horizons. Initial knowledge was zero, in total I spent about 30-40 hours of pure time. The day before yesterday I decided to stop hacking other people's templates and make something from scratch. The goal was to create a system administrator blog.
The result is codepen.io/anon/pen/qOJpYz (content added randomly, just for the sake of filling)
Questions:
1. Is this a normal layout for a beginner?
2. What shortcomings are striking?
3. well, any other criticism / advice / comments ...

Answer the question

In order to leave comments, you need to log in

3 answer(s)
C
Cat Anton, 2015-11-08
@rad1us

It's sad: href="C:\mycite\index.html"
Div didn't close:

<a href="C:\mycite\index.html"><div class="logo">
    <h1>Заметки сисадмина</h1>
    <p>Настройки, решения и прочее...</p>
</a>

In HTML5, the encoding can be specified more simply. There are also article, footer, header, nav tags and a bunch of others that could be used.
There is no point in writing each time font-family: Arial, Helvetica, sans-serif;if it has already been done for body.
Unusual code style:
.article{
  width:100%;
  height:100%;
}

Learn not to lose spaces:
.article {
    width: 100%;
    height: 100%;
}

Z
zooks, 2015-11-08
@zooks

It's ok for a beginner, but don't use absolute Windows paths C:\mycite\, make them relative.
As well as:

  • The encoding is defined in the old way.
  • Identification is not used.
  • Designed on divs - no semantic HTML5 tags (header, main, article, aside, footer).

N
Neron, 2015-11-08
Lordov @Nekto_Habr

Norm keep it up

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question