How can the code section be improved?

Question

JavaScript

ngAfterViewInit() {
        combineLatest(...this.filtersList.map((f) => f.filtersChanges)).subscribe(
            (selectedFilters) => {
                const filterUrlCombiner = new FilterUrlCombiner();
                const filterUrlBuilders = selectedFilters.map((filter) => new FilterUrlBuilder(filter, ComparingOperation.eq));
                filterUrlBuilders.forEach((filter) => {
                    filter.buildStringUrl();
                });

                const filterUrls = filterUrlBuilders.filter((filter) => filter.url).map((filter) => filter.url);
                filterUrlCombiner.combineUrl(filterUrls);

                this.filterBy = filterUrlCombiner.getUrl();
                this.settingsService.setDistributionFiltersSettings(selectedFilters);
                setTimeout(
                    () => (this.buttonDisabled = !selectedFilters.some((item) => item && item.selected && item.selected.length > 0)),
                );
            },
            (error) => {
                console.log('ERROR: ' + error);
            },
        );
    }

The input code has an array of selectedFilters values , then it maps each FilterUrlBuilder array , and then generates a buildStringUrl value for each FilterUrlBuilder element .

At the end, it gives an array of generated urls to the class: And
filterUrlCombiner.combineUrl(filterUrls);

after that, assigns the result to a variable:

this.filterBy = filterUrlCombiner.getUrl();

Answer 1

filterUrlBuilders.filter((filter) => filter.url).map((filter) => filter.url);

This is usually done like this:

filterUrlBuilders.map(filter => filter.url).filter(Boolean);

In general, the whole question is in the classes FilterUrlCombinerand FilterUrlBuilder: are they really needed and do some useful work or does someone have an enterprise brain?