Answer the question
In order to leave comments, you need to log in
How can I improve my function?
Hello! I have different drop-down blocks in my layout when I click on a button.
So I hang the block opening event
$('button').on('click', function(){
$(this).toggleClass('act');
$('div').toggleClass('act');
});
$(document).on('click', function(event){
var target = event.target;
var closeByDocument = function(docTarget, butTrigger, triggerElem, removeClass, butTriggerBullClass){
// docTarget - Элемент, при клике по документу
// butTrigger - Кнопка открытия элемента
// triggerElem - Открытие блока, при нажатии на кнопку
// removeClass - Имя удаляемого класса с блока и кнопки
// butTriggerBullClass - Удалять ли класс у кнопки
if(docTarget !== $(triggerElem)[0] && !$(triggerElem).has(docTarget).length && docTarget !== $(butTrigger)[0] && !$(butTrigger).has(docTarget).length){
$(triggerElem).removeClass(removeClass);
if(butTriggerBullClass){
$(butTrigger).removeClass(removeClass);
}
}
};
// Закроем блок
closeByDocument(target, 'button', 'div', 'act', true);
});
Answer the question
In order to leave comments, you need to log in
do caching and do not do unnecessary operations! why look for elements of the same type on each click, or why redefine a function that does not change the logic on each click? it can be done once and then called.
var divs = $('div');
$('button').on('click', function(){
$(this).toggleClass('act');
divs.toggleClass('act');
});
var closeByDocument = function(docTarget, butTrigger, triggerElem, removeClass, butTriggerBullClass){
// docTarget - Элемент, при клике по документу
// butTrigger - Кнопка открытия элемента
// triggerElem - Открытие блока, при нажатии на кнопку
// removeClass - Имя удаляемого класса с блока и кнопки
// butTriggerBullClass - Удалять ли класс у кнопки
if(docTarget !== $(triggerElem)[0] && !$(triggerElem).has(docTarget).length && docTarget !== $(butTrigger)[0] && !$(butTrigger).has(docTarget).length){
$(triggerElem).removeClass(removeClass);
if(butTriggerBullClass){
$(butTrigger).removeClass(removeClass);
}
}
};
$(document).on('click', function(event){
var target = event.target;
// Закроем блок
closeByDocument(target, 'button', 'div', 'act', true);
});
The simplest example of a modal window: jsfiddle.net/ph8zd19j/1
Instead of creating 100500 different popup blocks, you can copy them inside one #modal
I can sketch an example.
Didn't find what you were looking for?
Ask your questionAsk a Question
731 491 924 answers to any question