M
M
MurloDin2020-09-08 17:09:01
css
MurloDin, 2020-09-08 17:09:01

Finished my first React+Redux project, can anyone take a look and tell me what to work on?

Finished my first React+Redux project. I would like to hear criticism from experienced developers. Here is a link to the repository: https://github.com/MurloDin/Pet-Shelter
I also had a question about the implementation of Sass, my components are divided into folders, and each component has its own css, I should use sass for each component separately? It doesn't seem convenient to me.

Answer the question

In order to leave comments, you need to log in

2 answer(s)
N
Nikita Mikhailov, 2020-09-08
@Psixodelik

first_section , second_section , and so on are not the best component names. What is the first second component? And if the components are interchanged, then the logic will be preserved?

It doesn't seem convenient to me.

Why? What will be the difference between css and sass files? Ultimately, all this should compile into one single code.
my-container is your container and yours. And why yours and how it differs is not clear.
In general, I propose to start with naming. There are many places where you can work with this. So I looked, not knowing what kind of project and did not understand anything from the names of components and classes

K
Kirill Makarov, 2020-09-08
@kirbi1996

Components with capital letters are called, and about scss, the structure is something like this
The components folder in it with capital letters the MyComponent folder inside it is MyComponent.js and MyComponent.scss
And inside the script file you type
'. /MyComponent.scss'
So it's ok to use the preprocessor

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question