D
D
Danil Polyansky2020-03-08 14:10:10
Design
Danil Polyansky, 2020-03-08 14:10:10

Evaluate the junior site, what are the disadvantages?

Website: https://danilpolyanskiy.github.io/index.html

I'm a junior in web development, it's interesting to know other people's opinions about this site.

Answer the question

In order to leave comments, you need to log in

1 answer(s)
X
xdevelx, 2020-03-08
@danil_polyanskiy

1. H1 and h2 tags should be used for headings, not everything.
2. The ul tag should contain list items, not links. https://developer.mozilla.org/ru/docs/Web/HTML/Ele...
3. The img must have an alt attribute (empty for decorative ones)
4. The markup must be checked with the https://validator.w3 validator. org/
5. Icons should not be in png, but svg (and combined into a sprite)
6. The width and height of the button should not be fixed (at least min-width)
7. Containers of different widths are provided by the design?
8. letter-spacing: -0.4;-0.4 is how much? https://developer.mozilla.org/ru/docs/Web/CSS/lett...
9. Give the links in the menu padding - the user should not aim at the link area
10. Move scripts from head before </body>either attribute async
5e64d713beddc801162976.png
chrome dev tools => audits => accessibility obviously suffers

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question