Evaluate BEM layout?

Question

code review

Hello.. Please spare 5-7 minutes of your precious...

The new coder has completed the first task
. I would like to hear a few words from experienced typesetters, because. I didn’t do much on the backend and layout myself (only the basics).

https://github.com/Trydim/testhtml

Thank you very much for your attention.

Answer 1

<div class="heading-block">
                <h3 class="heading__h3">Продажа, производство и доставка</h3>
                <h1 class="heading__h1">Штакетник металлический</h1>
              </div>

not BEM

<div class="grid-block">
                            <span class="calc__span">Стоимость погонного метра</span>
                            <span class="calc__text">61 ₽/м </span>
                            <span class="calc__span">

the same thing, and a bunch of similar moments, where the element is nested in someone else's block, if you do this, then only when mixing. I can’t say anything about css, it looks like postprocessors are applied there.
Upd I can still say about css. Blocks are given an external indent, this cannot be done in the BEM either.

.header-item {
  margin-right: 47px
}

Answer 2

In general, bam is used, but there are strange moments when, let's say, the
calc_span class also applies to span, but if he has little experience, then I think it's not bad. As for css, judging by the fact that there is no semicolon, it definitely compiled there, I think that this is not bad. Unfortunately, I couldn’t see the quality of the layout from the phone, but if the layout designer is a beginner, I think you can direct it in the right direction