Code Review, how does it actually happen?

Question

Agile

Good afternoon, dear development gurus.
Can you please tell me what is usually meant by Code Review? Is it some live meetings where the coder says what he did and others ask questions or something else? I looked at publications on Habré and other resources on this topic, but everything there is very generalized and casual. with a bunch of laudatory reviews but do not reveal the actual essence of the concept. A friend of the courses says that they have a Code Review, this is when one of the mentors / teachers looks at your code online and gives comments as they go. Which interpretation is the most correct?

Answer 1

Well, this is a review of the code by a person who did not write the code. It is necessary in order to be able to notice some errors and all that in the code. It's very common to check joon code before pushing that code to the master branch. There are companies where your code must be reviewed by another programmer before it is added to the master branch, even if you are an experienced senior.

Answer 2

There are special tools for Code Review. For example, on Github, you can review any pull request and comment on any line of code. Those. can be done remotely with no problem.

Answer 3

Here is a good answer to your question: habrahabr.ru/post/142564
In my opinion, CR is the only way to deal with hard-to-find errors that usually cannot be reproduced in tests, and which, due to a cunning interweaving of circumstances, do not allow our users to work quietly.
Moreover, we have three levels of struggle, each of which uses CR: during detailed design, the architect or lead developer analyzes the finished code for correct intervention in its operation (the "do no harm" principle) and for the reuse of ready-made components, then, after implementation, it is carried out a review of the code for its optimality and a detailed understanding of the principles of operation of the implemented component (the latter is important for developers who will use the component in further work on the code), and, of course, when diagnosing system failures.