What's wrong with the number of commits a little more than for which the task could actually be solved?

@

@Twitt2019-09-10 14:32:18

git

@Twitt, 2019-09-10 14:32:18

I got a new job, set a task, made one commit in the branch, they said at the review that I could solve it a little differently. As a result, I made 4 more commits, the reviewer says: "there are already 5 commits, let's get a new PR".
What is the problem with 5 commits, can someone tell me?

Reply

Answer the question

In order to leave comments, you need to log in

2 answer(s)

A

Anton Shvets, 2019-09-10
@Xuxicheta

In the personal cockroaches of the reviewer. If the commits soar when merging the PR, you can mold the commits into one.
On the contrary, the fewer changes in the commit. all the better. I suffer from the opposite, at the end of the day you make a commit, then you won’t understand all this.

N

Northern Lights, 2019-09-10
@php666

in an ideal world where everyone poops butterflies, a commit should be a complete phase of some kind of editing, implying that a specific (sub)task has been completed and a fix has been made to the system that does not require modifications and guarantees the system to work.
In real life things are different.
your 5 commits - from excitement.
in fact, you just had to check everything and make another commit.
why is there PR I don’t understand