What is the best way to shorten the method, the controller, so that it would be easier to test it?

Question

Laravel

Now here is such a bold method

public function store(Request $request)
    {
       $rules = [
           'description' => 'min:4',
           'image' => 'required|image|mimes:jpg,jpeg,png',
           'choose-category' => 'array|required'
           ];
    
        $messages = [
            'description.min' => 'Название должно содержать минимум :min символа.',
            'image.required' => 'Изображение загружать обязательно.',
            'image.image' => 'Вы загрузили не изображение.',
            'image.mimes' => 'Допустимые форматы: jpg, jpeg, png.',
            'choose-category.required' => 'Выберите категорию'
         ];
    
        Validator::make(
            $request->all(), 
            $rules ,
            $messages
              )->validate(); 
     
      $image = $request->file('image');
      
      $description = $request->input('description');
      
      $this->imageClass->add($image, $description);
  
      $this->imageClass->save();

      $idNewImage = $this->imageClass->id;
      $categories = $request->input('choose-category');
      
      $relation = \App\Services\Image::find($idNewImage);
        
      $relation->categories()->attach($categories);
      
      return redirect('/');
    }

Should the validation be put into the model and only tested if it was successful or not?
For example, in the controller would be

$validation = this->imageClass->validation($request->all());

But what about the rest of the code, and leave it like that?

Answer 1

https://laravel.ru/posts/864 - not a direct answer to your question, but a good article not on this topic

Answer 2

Move validation into a separate request - https://laravel.com/docs/5.7/validation#creating-f...

Answer 3

Yes, validation in separate files is very convenient
php artisan make:request FileRequest
and transfer the rules and messages there, and connect it in the controller via use and use it in the method (FileRequest $request). The rest of the code is great)) You can also add variable checks, for example, if($relation)... etc. to eliminate errors, add also access rights to the method and, of course, connect json upload for js