What is the best way to refactor?

Question

Ruby on Rails

class Reservation < ActiveRecord::Base

  validates :table, presence: true
  validates :start, presence: true
  validates :finish, presence: true


  validate :checking_the_time, :uniqueness_reservation

  scope :tables, ->(table) { where("'reservations'.'table' = ? ", table) }

 
  def checking_the_time
    if start >= finish
      errors.add(:finish, "Invalid time range")
    end
  end

  def uniqueness_reservation
    unless Reservation.diapazone(start, finish).tables(table).where.not(id: id).empty?
      errors.add(:booked_from, 'Invalid period.')
    end
  end


  private

  def self.diapazone(start, finish)
    where("(start >= :s AND finish <= :f) OR (start <= :s AND finish >= :s)
             OR (start <= :f AND finish >= :f)",
          {s: start, f: finish})
  end


end

help with uniqueness_reservation validation refactoring, validation so that the new order does not intersect with the existing one

Answer 1

In general, programming is not done in machine codes for a long time. A little business logic wouldn't hurt b. What are tables? Do you rent an apartment and check that there is only one order in one time interval?
Then everything is easier