What is the best way to design a class?

Question

PHP

Greetings. I am working on projects in Laravel. I have a helper class that does some work with the data and also works with the database (using the ORM model). Now I have implemented a helper class like this:
Helper class:

class MyHelperClass
{
    private $model;
    private $data;

    /**
     * @param $data
     * @param SpecificModel $model
     */
    public function __construct($data, SpecificModel $model)
    {
        $this->model = $model;
        $this->data = $data;
    }

    public function doWork()
    {
        $concreteModel = $this->model->find(123);
        $concreteModel2 = $this->model->find(456);

        // какой то код, работающий с моделью...

        $concreteModel->save();
        $concreteModel2->delete();
    }
}

Somewhere in the code:

// SpecificModel - ORM модель
$helper = new MyHelperClass([1, 2, 3, 4], new SpecificModel());
$helper->doWork();

Is this the right approach? Or is it possible to create an object directly in the helper without passing it as a constructor argument?

Answer 1

json_decode

Answer 2

Creating a service (helper) directly is not the best approach, inject it into an action method. DI will create the helper itself and inject the SpecificModel into it, and you will be able to mock it during testing.

class FooController {
    public function getIndex(\MyHelperClass $helper) {
        $helper->doWork([1, 2, 3, 4]);
    }
}

Answer 3

yes, the normal approach from the SOLID principle (in your case, the dependency inversion principle D). when you test MyHelperClass you will create the tested object as isolated as possible from other classes
$this->object = new MyHelperClass([1, 2, 3, 4], $mosk);
the $mosk object will return a prepared result