What does the RubyMine warning mean: controller action should call one model method other than an initial find or new.?

Question

Ruby on Rails

The controller has a method:

def create_country
    @country = Country.new(country_params)
    begin
      #сохраняем модель
      @country.save
      #это метод другой модели
      CountryTvText.create_or_update_for_country @country.id, params[:country_tv_text]
      flash[:notice] = "Страна добавлена"
    rescue Exception => e
      flash[:error] = e.message
    end
    redirect_to admin_panel_path
  end

And RubyMine highlights two lines with a warning: controller action should call one model method other than an initial find or new

@country.save
CountryTvText.create_or_update_for_country @country.id, params[:country_tv_text]

What am I doing wrong? :)

Answer 1

Don't do this in the first place:
And after you rewrite it to something like

if @country.save
...
else
...
end

You look, and the error will disappear by itself)
Well, as for rubymine, although I don’t use it, it seems that the point is that it sees that under certain conditions your method will consist of object initialization and no further actions with it (apparently, when the exception will silently pass by). But here I could be wrong.

Answer 2

controller action should call one model method other than an initial find or new
This is a warning that you are using more than one model method in a controller.
Read "Rails best practices"