M
M
Maxim Makarov2022-01-25 14:55:51
Python
Maxim Makarov, 2022-01-25 14:55:51

Rate the test?

Good day everyone, the other day I did a test task, but for some reason it was not accepted without indicating errors or problems. If anyone has extra time, you can look and constructively point out my mistakes

link to the project

Answer the question

In order to leave comments, you need to log in

2 answer(s)
S
soremix, 2022-01-25
@SoreMix

The task itself will not be? There is really nothing to evaluate. There are a lot of grammatical errors in the description. You can end here, it already speaks of a bad approach. Here it is with no comments at all.
61eff88f8b71b313754399.png
There are a lot of commits with a change in the readme, because you can write correctly once and not edit 10 (literally) times. To be honest, I wouldn't even look any further at this point. The "documentation" itself is written in absolutely no way.
SQL queries are incorrect. Variable naming is different. Some variables do not understand why they exist, as, for example, errorin the authorization method.
https://github.com/chigan0/apptrix.test/blob/main/...
`utils` are licked from somewhere, for some reason there are tabs everywhere, when there are spaces in the rest of the code.
Beautiful
61effb278a845424859968.png
English words are misspelled in the same way.
The dock does not match the code.

?lastname filter by last name

In the code:
"last_name" in request.args
I don’t do JS development, but for the first time I see that the form is formed not through the form tag and / or using ajax, but simply by putting inputs on the page, without an attribute nameand then collecting them manually in formdata, and throwing them to the server via fetch .
Extra comments in the code, leftovers from some tests. Indents jump. And so on And so on And so on. And all this before testing the main functionality of the application

I
Ivan Yakushenko, 2022-01-25
@kshnkvn

Because everything is very bad, literally in every line of code. Complete non-compliance with PEP8 wherever possible.
main.py and settings.py are usually kept at the root of the project.
Storing any keys and / or passwords directly in a .py file, and even more so uploading it to github, is a disgusting practice.
The project structure is missing in principle:
- Why do you have a database configuration in the models folder?
- Why do you have the database connection parameter right in the file where the connection takes place, and not in the config?
- Why create_database.py file at all ?
Having run through the rest of the files, there is no desire to disassemble them purely for comment - there is complete darkness.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question