Answer the question
In order to leave comments, you need to log in
Rate the test?
Good day everyone, the other day I did a test task, but for some reason it was not accepted without indicating errors or problems. If anyone has extra time, you can look and constructively point out my mistakes
link to the project
Answer the question
In order to leave comments, you need to log in
The task itself will not be? There is really nothing to evaluate. There are a lot of grammatical errors in the description. You can end here, it already speaks of a bad approach. Here it is with no comments at all.
There are a lot of commits with a change in the readme, because you can write correctly once and not edit 10 (literally) times. To be honest, I wouldn't even look any further at this point. The "documentation" itself is written in absolutely no way.
SQL queries are incorrect. Variable naming is different. Some variables do not understand why they exist, as, for example, error
in the authorization method.
https://github.com/chigan0/apptrix.test/blob/main/...
`utils` are licked from somewhere, for some reason there are tabs everywhere, when there are spaces in the rest of the code.
Beautiful
English words are misspelled in the same way.
The dock does not match the code.
?lastname filter by last name
"last_name" in request.args
name
and then collecting them manually in formdata, and throwing them to the server via fetch . Because everything is very bad, literally in every line of code. Complete non-compliance with PEP8 wherever possible.
main.py and settings.py are usually kept at the root of the project.
Storing any keys and / or passwords directly in a .py file, and even more so uploading it to github, is a disgusting practice.
The project structure is missing in principle:
- Why do you have a database configuration in the models folder?
- Why do you have the database connection parameter right in the file where the connection takes place, and not in the config?
- Why create_database.py file at all ?
Having run through the rest of the files, there is no desire to disassemble them purely for comment - there is complete darkness.
Didn't find what you were looking for?
Ask your questionAsk a Question
731 491 924 answers to any question