Layout after 4 months of training. How do you like the result?

colorkid2015-09-05 18:23:31

Layout

colorkid, 2015-09-05 18:23:31

About 4 months ago I began to study layout. Slowly I made up and studied htmlacademy and other textbook services.
Two weeks ago, I started making up a training layout from htmlacademy - "Sedona". He showed imagination in some nuances and adaptability.

I want to ask your opinion about the results of 4 months of training, how do you like my layout? Where are the mistakes? What to pull up?
colorkid.ru/sedona/index.html
colorkid.ru/sedona/catalog.html
colorkid.ru/sedona/hotel.html

Answer the question

In order to leave comments, you need to log in

15 answer(s)

Elena Novodvorskaya, 2015-09-07
@colorkid

Learn BEM and rejoice when you need to cover something or change something that is covered, because.

.main-nav ul li a {}

not comme il faut)

LMI, 2015-09-05
@LMI

Not bad, but there are a lot of errors in the validator. Images should be done as sprites.

Igor, 2015-09-10
@Lopar

Consider me outdated, I don’t know, but these “airy” styles didn’t impress me before, and now they don’t at all. Big pictures, passable typography, but information, motherfucking, information. There is none. And sites are made for the sake of information, no?

OnYourLips, 2015-09-05
@OnYourLips

The code is unpleasant to read: indentation is different everywhere, script tags can be optimized.
But adaptability is good.

Dmitry Sergeevich, 2015-09-05
@CheckOneTwo

Curved selects on the form below.

Alexander, 2015-09-10
@lebonnet

for html5 use

<!--[if lt IE 9]><script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script><![endif]-->

use css reset
load minified scripts
remove all js code in a separate file

Alex, 2015-09-05
@mr_ko

joxi.ru/gmv6Gk7ulo3Pma the background is too small.
And here it is desirable to give a rading joxi.ru/DmB1k6xi3LDVrP

zooks, 2015-09-05
@zooks

IE7 does not need to be supported, IE8 only at the strong request of the customer.
UTF-8 encoding is traditionally capitalized:
I see unnecessary trailing slashes that are only needed for XHTML.
It is also not clear why the design element should be wrapped in a figure, this tag is needed for figures in articles.
In Firefox, a one-pixel stripe crawled out under it. So there was no test in different browsers.

Andrey Fedorov, 2015-09-05
@aliencash

Whoa whoa! Adaptability!!! Respectos. )

sumanai, 2015-09-06
@sumanai

.modal:target > div {
  -webkit-animation-name: bounce;
}

Do we have other browsers?
And it would be nice to flavor everything with micromarking.

GoodProject, 2015-09-06
@GoodProject

Fine!
And can you link to the layout on which the typesetting?

oknechirik, 2015-09-10
@oknechirik

Another point, in the header through catchy comments, support as much as IE7 (it is clear that HTML5 bolierplate and all things), and flex is only in standard fashion. That is, neither IE10, nor even the current Safari is supported.
And so the norms for a start, even completely.

Elizaveta Borisova, 2015-09-06
@Elizaveta

Who wants to learn how to type faster?

Ildar Gabitov, 2015-09-10
@JunWebMaster

Hello everyone, how do you like my result of adaptive layout in HTML in a couple of weeks, since I started learning layout from scratch :)
True, it was done using step-by-step instructions from Treehouse.
I even purchased a domain with hosting in order to make a portfolio out of it in the future:
ildargabitov.com/index.html
cool, I just noticed that the chat understands HTML code :) I'm looking
for a Jedi Mentor in order to reach my goal - Frontend developer.
Py.Sy. Lots of ideas, lots of energy, little time.

arsenty, 2015-09-11
@arsenty

Safari 8, Mac OS X 10.10
https://www.dropbox.com/s/i1cg1a7mdlixjqf/colorkid...
You may find this browser and OS uninteresting :), but it should not look like this in any modern browser of the latest version.