A
A
aleksandrkotov2022-01-30 02:18:14
git
aleksandrkotov, 2022-01-30 02:18:14

Is it safe to delete a pull request?

There is a develop branch. For the new task, I created the "add button" branch. I made a button on this branch, committed and pushed it to github, then made a pull request for code review and then made a checkout in develop in the terminal. But I remembered that I did not export the configuration, and the configuration was not added to the indexing, it was not comical and, accordingly, it is not in the pull request on the github.

I think to do this:
1. Delete the Pull request on the github or close it if it is not possible to delete it.
2. Add configurations to indexing, commit, push.
3. Make a new pull request

Will the new pull request contain the code that is responsible for creating the button if the branch has already been pushed to github? Or will there be only configuration code and then you should not delete the old pull request?

In this situation, would it be better to create a new commit on the "add button" branch and issue another pull request?

Answer the question

In order to leave comments, you need to log in

1 answer(s)
S
Sergey Kuznetsov, 2022-01-30
@aleksandrkotov

No need to delete anything to refine the task!
Just go back to your topic thread. Add new commits with fixes and push them to github.
Your Pull Request will be updated automatically .
Similarly, if there are comments on the Code Review, then you simply fix them locally in the same subject branch and push. Improvements will immediately fall into the Pull Request.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question