U
U
Uncle Bogdan2021-05-04 11:17:43
Unity
Uncle Bogdan, 2021-05-04 11:17:43

How to make this not govnokod?

Here is the code to build the computer. how to improve it?

shitcode
using UnityEngine;

public class MotherBoardPlace : MonoBehaviour
{
    private void OnCollisionEnter(Collision collision)
    {
        switch(collision.collider.tag)
        {
            case "Processor":

                collision.rigidbody.isKinematic = true;
                collision.rigidbody.detectCollisions = false;
                collision.rigidbody.useGravity = false;
                collision.transform.parent = transform;
                collision.transform.eulerAngles = new Vector3(0, 0, 0);
                collision.transform.localPosition = transform.Find("ProcessorPlace").localPosition;
                break;
            case "ram":

                collision.rigidbody.isKinematic = true;
                collision.rigidbody.detectCollisions = false;
                collision.rigidbody.useGravity = false;
                collision.transform.parent = transform;
                collision.transform.eulerAngles = new Vector3(-90, 0, 90);
                collision.transform.localPosition = transform.Find("RamPlace").localPosition;

                break;
        }
    }
}

Answer the question

In order to leave comments, you need to log in

1 answer(s)
C
cicatrix, 2021-05-04
@cicatrix

DRY = Don't Repeat Yourself (do not repeat)
At least take out the assignment of properties in a separate module. Set the default to not assign each time. Replace string tags with string constants.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question