How to get the value of an xml tag in C#?

Question

C++ / C#

I'm new to C#, so far I'm doing it by examples, trying to modernize the code. But I got up, I don’t understand how to correctly extract the value of the cityname2 tag from this file: www.eurometeo.ru/russia/moskva/export/xml/data
Here is the code:

string sity = @"http://www.eurometeo.ru/russia/moskva/export/xml/data/";

            string xmlData = new WebClient().DownloadString(sity);

            var xmlColItems = XDocument.Parse(xmlData);

            string text = xmlColItems.Descendants("weather")
                                  .Descendants("city")
                                  .Descendants("cityname2").ToString().Value;

            Console.WriteLine(text);

The tag itself (the element displays), but as a value, something does not work out. When adding .Value , it displays an error:

I still don’t really understand what this means, help me figure it out.

Answer 1

Try swapping Value and ToString(). ToString() itself converts the object to a string, no further action on the string is needed.

Answer 2

string sity = @"http://www.eurometeo.ru/russia/moskva/export/xml/data/";
string xmlData = new WebClient().DownloadString(sity);
var xmlColItems = XDocument.Parse(xmlData);
var query = xmlColItems.Descendants("weather").Descendants("city").Select(p => new { c = p.Element("cityname2").Value }).ToList()[0];
string text = query.c.ToString();
byte[] bytes = Encoding.Convert(Encoding.Unicode, Encoding.GetEncoding(1251), Encoding.Unicode.GetBytes(text));
text = Encoding.UTF8.GetString(bytes);
Console.WriteLine(text);

Answer 3

Try like this:

string text = xmlColItems.Descendants("weather")
                                  .Descendants("city")
                                  .Descendants("cityname2").FirstOrDefault()?.Value;

Answer 4

You don't have a Value property because you always return a collection of XElements.
You either need to loop through this collection, or bypass it through LINQ and take the Value from the elements.