M
M
mirador2015-12-18 19:11:06
css
mirador, 2015-12-18 19:11:06

Did you make your first template normally?

Hello. I recently started studying html & css in my free time, so I decided to make my first small psd. Made it up in about 8 hours. Thanks in advance =)
Files
The site itself
PS I guess that css is not optimized =)
Now there is some problem in Chrome, it does not load adspace.jpg images in div id="space", in the console it says "Failed to load resource: net: :ERR_BLOCKED_BY_CLIENT". It works in all other browsers and the local Chrome file itself loads without problems. Please help

Answer the question

In order to leave comments, you need to log in

6 answer(s)
Z
Zvezdocheteg, 2015-12-21
@Zvezdocheteg

Use classes for element names, and id is a unique element name that can only be used once in a document. I see I tried to use it several times in the content section, because of this it didn’t work out.
!important is very bad to use !
Vertical margins for elements that are located one below the other are best set from the bottom (that is, push the element lying below), such as you have in the blog section.
Social icons are best done through the list ul > li > a , alignment applied to li, other styles to "a".
Take the courses at https://htmlacademy.ru/courses , the very basics are there, and then lay out the layout for fixing.
And here is the layout checklist for the future https://github.com/delka/html5checklist/
Yes, and I advise you to master the github in order to spread your layout there, and indeed a useful thing.
Good luck in learning, the start is put, this is the main thing !!))

B
Boris Yakushev, 2015-12-18
@za4me

Make yourself a free hosting account, and don't torture people with codepen to view your templates :)
upd: using id is not comme il faut

S
Sergey, 2015-12-18
@Sergey_net_it

Link broken....

A
Andrey Berezhnoy, 2015-12-18
@AndreyBerezhnoy

reset.css is obsolete.
look towards normalize.css

I
Ilya Pirozhok, 2015-12-18
@kamikadze1996

In general, not bad, there is nothing superfluous. There are some flaws in the code

A
Andrey Verkh, 2015-12-19
@sadisme

Using an ID is bad. Use classes.
If you're using html5, then use elements like header, footer, nav, article, aside...
Setting line-height to px is bad. Leave just a number without a unit.
For pictures, do not forget to set vertical-align:top, otherwise there will be indents.
Pictures that relate to the design, it is desirable to set css background.
Buttons
There are many more small things, but this is the main one.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question