G
G
Gnoemes2017-09-18 19:10:25
Programming
Gnoemes, 2017-09-18 19:10:25

******DELETED***********?

/////////////////////////////////////////////////// /////////////////////////////////////////////////// /////////////////////////////////////////////////// /////////////////////////////////////////////////// /////////////////////////////////////////////////// /////////////////////////////////////////////////// ////////

Answer the question

In order to leave comments, you need to log in

3 answer(s)
M
Maxim Timofeev, 2017-09-19
@Gnoemes

To answer your question, you need to do a lot of work, at least parsing your code.
No one will spend so much time on you, and this site is not for that. Find a guru in your freelance question, pay him a couple of hours of consultations and get answers, moreover, the right ones, and not what I can write out of the corner of my eye looking at your code.

E
Eugene Ray, 2017-09-19
@firezhek

Looked very briefly.
Jambs -
1) You catch unchecked exceptions, catch (NullPointerException) - well, that's it))
2) There is no java dock at all
3) Magic numbers - array[1] array[2] array[3] array[4] - only a developer that wrote this, he knows what lies there)
4) You can be a hipster and connect lombok to remove getters, setters, the code will become cleaner

V
vlad2711, 2018-01-02
@vlad2711

I can say that judging by the screenshots, the attachment is good and it’s not a shame to show it, but to point out jambs and other errors you need to dig a lot, though there are things that catch your eye:
1) magic numbers and the lack of constants (for example, in mainActivity: loadFragment(" news") - "news" can be moved to the Constants class and refer to the constant).
2) multi-storey ifs in the adapter, which, well, are not buzzing at all and, ideally, make some kind of switch, of course, you need to think, but the code will become cleaner.
3)

@BindView(R.id.news_date)
TextView mDate;

Everything seems to be ok here and many do it, but in fact it can be done like this:
@BindView(R.id.news_date) TextView mDate;the code is shorter and somehow more beautiful, and this does not contradict the code style.
4) Lack of tags. You simply don’t have them, and you just do logging without tags, which is not good.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question