V
V
Valentin Khokhlov2017-09-27 13:56:45
css
Valentin Khokhlov, 2017-09-27 13:56:45

Criticize the layout, guys?

Guys, good afternoon!
Look at the layout, it's not difficult for anyone: https://hohlovvalentin.github.io/down_the_stream_page/
Code in the debugger, or here: https://github.com/HohlovValentin/down_the_stream_page
Pay attention to the correctness / incorrectness of the application of BEM, SCSS, semantics, adaptability. Everything looks good on the phone.
Now I went through interviews, received several refusals in a row, but I realized what employers want to see and again sat down for training.
How long will such a page take for a good layout designer?
Now I'm trying to get through to an intern, is that enough? It is clear that everywhere the requirements are different, but still the overall picture should be visible.

Answer the question

In order to leave comments, you need to log in

5 answer(s)
A
alvvi, 2017-09-27
@guinnessdark

How long will such a page take for a good layout designer?

I will not speak for all the good ones, but it would take me 2 hours.
The semantics is lame, even very: headings with a tag , a tag that is deprecated instead of the obvious article, a modifier called _mod is also cool, because it’s immediately clear what it does, right?) I didn’t look deeper, because these are pretty gross mistakes.<a><content></content>
No, not enough. Take a free beautiful layout with design and dynamics, or a ready-made website and make it up. If you can and do it semantically, then the time has come.

A
Andrey Perov, 2017-09-27
@SnaIP

within a few hours, about https://hohlovvalentin.github.io/down_the_stream_page/ or maybe faster,
I would typeset from smaller to larger, first I selected all the button common moments, inputs, etc. I made everything using BEM, and then how the designer assembled all this in blocks (but of course everything depends on the situation what needs to be done)

E
Egor Zhivagin, 2017-09-27
@Krasnodar_etc

Why compress body ? don’t do it)
Yes, everything is more or less normal, but you took a template from zero. Do something like

A
Anna_BS, 2017-09-27
@Anna_BS

The site is easy, you need to take something more difficult. Make a couple more sites.
uplabs
On mobile there will be a very small font, the adaptive menu is very transparent, it is better to remove the animation on "read more" altogether.
In general, it is better to take a good layout with adaptation so as not to invent it yourself.

M
Maxim Timofeev, 2017-09-27
@webinar

1. This is too primitive, it’s not worth showing like this because there is a hint that you won’t make it harder.
2. Design still matters. At least for the first impression. You look at this and subconsciously already want to find flaws, which means they will find them.
3. What is your css code doing in the header? Well, I understand when cms is necessary, but for a simple template, this can be clearly transferred to a file.
4. Why isn't css minified and compressed into 1 file?
5. Why is google maps connected 18 times?
6. In a mobile phone, the menu is completely unreadable. This is anti UX
7. I will not say anything about semantics, it is still far from it.
8. BEM was not even worth trying given the level of everything else.
It's so dripped tops.

Didn't find what you were looking for?

Ask your question

Ask a Question

731 491 924 answers to any question