Add a return statement to this callback Sonarlint?

Question

JavaScript

Object.entries(items).map(element => {
            if (commentId === element[1].id) {
                 items.splice(element[0], 1);
            }
        });

Answer 1

map should return some value for the new array, like:

const newArray = oldArray.map(value => {
  return value * 2;
});

what you are trying to do should probably look like this:

const idx = items.findIndex(comment => comment.id === commentId);
if (idx > -1) {
  items.splice(idx, 1);
}